rudder icon indicating copy to clipboard operation
rudder copied to clipboard

Fixes #27103: Update front-end dependencies

Open clarktsiory opened this issue 6 months ago • 6 comments

https://issues.rudder.io/issues/27103

We now need to include ESM modules as the newer JS libraries, here jsondiffpatch are switching paradigm, or we could not upgrade (this is also the case for chartjs, but hopefully it still ships UMD dists). So there is some change in the gulpfile, we need to include the modules tree : there are javascripts imports and a single javascript entrypoint file is no longer sufficient to embark a library.

For bootstrap, the dependency upgrade is not breaking, there are simply some warnings that can be ignored from gulp, as discussed here, and it requires pinning the version of sass. Also the gulp-sass plugin API exposes a synchronous version which is reported to be more efficient.

There is some dependency vulnerability which needs to be fixed with an override because the package has not an up-to-date npm release but only a fix in the github source without any release (we should watch for upcoming versions of this package)

clarktsiory avatar Jun 17 '25 08:06 clarktsiory

Commit modified

clarktsiory avatar Jun 17 '25 16:06 clarktsiory

Commit modified

clarktsiory avatar Jun 18 '25 08:06 clarktsiory

Commit modified

clarktsiory avatar Jun 18 '25 08:06 clarktsiory

PR updated with a new commit

clarktsiory avatar Jun 19 '25 07:06 clarktsiory

PR updated with a new commit

clarktsiory avatar Jun 19 '25 10:06 clarktsiory

PR updated with a new commit

clarktsiory avatar Jun 19 '25 10:06 clarktsiory

PR updated with a new commit

clarktsiory avatar Jun 23 '25 09:06 clarktsiory

PR updated with a new commit

clarktsiory avatar Jul 02 '25 16:07 clarktsiory

This PR is not mergeable to upper versions. Since it is "Ready for merge" you must merge it by yourself using the following command: rudder-dev merge https://github.com/Normation/rudder/pull/6460 -- Your faithful QA Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason." (https://ci.normation.com/jenkins/job/merge-accepted-pr/103428/console)

OK, squash merging this PR

clarktsiory avatar Jul 03 '25 07:07 clarktsiory

PR rebased

clarktsiory avatar Jul 03 '25 07:07 clarktsiory

OK, merging this PR

clarktsiory avatar Jul 03 '25 07:07 clarktsiory