rudder icon indicating copy to clipboard operation
rudder copied to clipboard

Fixes #25681: OIDC users are marked as deleted after a new user is provisionned

Open clarktsiory opened this issue 1 year ago • 4 comments

https://issues.rudder.io/issues/25681

We need to add the user instead of set all existing users with the current provisioned one. It just needs to reuse the setExistingUsers method, with the new user appended to the list of existing ones.

I added unit tests, that were not passing when another OIDC user is set.

clarktsiory avatar Oct 15 '24 16:10 clarktsiory

Commit modified

clarktsiory avatar Oct 16 '24 09:10 clarktsiory

Commit modified

clarktsiory avatar Oct 16 '24 09:10 clarktsiory

PR updated with a new commit

clarktsiory avatar Oct 16 '24 12:10 clarktsiory

PR updated with a new commit

clarktsiory avatar Oct 16 '24 12:10 clarktsiory

This PR is not mergeable to upper versions. Since it is "Ready for merge" you must merge it by yourself using the following command: rudder-dev merge https://github.com/Normation/rudder/pull/5951 -- Your faithful QA Kant merge: "Morality is not the doctrine of how we may make ourselves happy, but how we may make ourselves worthy of happiness." (https://ci.normation.com/jenkins/job/merge-accepted-pr/92139/console)

OK, squash merging this PR

clarktsiory avatar Nov 05 '24 07:11 clarktsiory