Normation
Fixes #24863: when we have compliance right, the rule page shows a weird message
https://issues.rudder.io/issues/24863
It seems like there is bigger issue under this one.
Initial issue
The initial problem was that when we go to a rule page, in Elm we initialize the page by fetching many information of which change-request's information that required administration_read right.
enable_change_message
enable_change_request
enable_self_deployment
enable_self_validation
enable_validate_all
Potential issue discovered
In the initialization of the Rule page, we check if change-request is enabled. This fetching is done through settings API GetAllSetings that required adminstration_read right
The main problem with this PR and logic is that an user for example with validator role will not see any change-request on a rule, because he doesn't have the administration_read access, and we don't want to great him with admin read because it can see other settings that are only meant for admin users.
Potential solution
One possibility would be to extract the change-request part of the GetAllSetings API to create something like GetChangeRequestSettingds, add appropriate rights to this in order for a validator (maybe other roles) user to retrieve this info
This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5678
-- Your faithful QA
Kant merge: "It is beyond a doubt that all our knowledge begins with experience."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/85525/console)
This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5678
-- Your faithful QA
Kant merge: "It is beyond a doubt that all our knowledge begins with experience."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/87242/console)