Fixes #26906: Migrate the ChangeValidationSettings snippet from Scala/lift to Elm
https://issues.rudder.io/issues/26906
PR updated with a new commit
Commit modified
Commit modified
Two of the info sections contradict each other.
- The "Configure change request triggers" section reads : "Be careful: a change request is created when at least one predicate matches, so an exempted user still need a change request in order to edit a node from a supervised group. ",
- While the "Configure users with change validation" reads : "Hence, configuring the [supervised] groups below will have no effect on validated users (in the list above), but will apply to non-validated users, who will still need to create a change request in order to modify a node from a supervised group. "
In addition, the "Supervised targets"' info section has an unfinished phrase : "Change validation are enable for any change that would impact a node belonging to one of the chosen groups below. Be careful: a change on one another group "
Should the info sections be modified ?
yes you can do improvements on the HTML content, it was in the HTML template but now it's in an Elm file so if you don't do it in Elm, it will not be fixed (if we also fix it in previous version with HTML, it will need to be fixed by hand in the Elm file during upmerge)
I don't know which one is correct, so it needs to be tested
The only other tasks left that I can think of for this PR are :
- Maybe changing some of the contents of the info-sections : see https://github.com/Normation/rudder-plugins/pull/832#issuecomment-2948416828
- The checkboxes in the WorkflowUsers app are not styled : they are default checkboxes unlike the rest of the page, which uses the
fa fa-checkclass. Should these checkboxes also usefa fa-check?
- For the info section, this is not urgent, as it impacts previous versions first, so later we would make a dedicated fix for that
- For checkboxes, ideally we should normalize using bootstrap 5 checkboxes and we would need to synchronize the Elm model with the
inputs, but if it's too complicated we can keep it as it is
OK, merging this PR