Norigin-Spatial-Navigation icon indicating copy to clipboard operation
Norigin-Spatial-Navigation copied to clipboard

Built index.js has ES6 functionalites (Reflect) - Build not es5 compliant

Open MFlyer opened this issue 1 year ago • 2 comments

Describe the bug 1.1.1 Built version of Norigin Spatial Navigation is not es5 compliant

To Reproduce Include it in a project and make it run on Chrome<49 / Browser without Reflect API support (it's from ES6)

Expected behavior A built version without Reflect

Screenshots Not required

@adrian-wozniak - @asgvard

MFlyer avatar Oct 14 '22 13:10 MFlyer

Hello @MFlyer!

Thanks for opening an issue about this - It's a fair point, Reflect is not part of the ES5 spec.

I guess we could substitute this for delete (although that keyword feels kinda weird to use), or use a shim (which inherently would do the same).

@asgvard: What do you think?

predikament avatar Oct 17 '22 15:10 predikament

Hi @predikament & @asgvard , my suggestion: I had a local git clone and used babel with corejs instead of the ts-loader -> targeting something not having ES5 support (e.g. a chrome 38) will grant you a full es5 compliant index.js - tested working (on a real tv device using an old Chrome 47)

MFlyer avatar Oct 17 '22 22:10 MFlyer