cypress-wait-until icon indicating copy to clipboard operation
cypress-wait-until copied to clipboard

Published 20 hours ago • verified publisher icon NoriSte

Move the Cypress tests to TypeScript

Open NoriSte opened this issue 5 years ago • 6 comments

Today I imported this plugin into a TypeScript-based Cypress project. TS did not like the old definition (that's why I fixed it with #17 ) but we must avoid that the end user discovers it himself.

That's why I propose to move the Cypress test to TypeScript. @allevo do you want to do that? 👋

NoriSte avatar Jun 26 '19 10:06 NoriSte

Pull request is already merged so could you close this issue? :)

Lukaszli avatar Oct 28 '19 11:10 Lukaszli

Hi @Lukaszli , the closed PR was "update the TS definition" while this one is "translate the existing cypress tests to TS" so, no, it could not be closed yet 😊

NoriSte avatar Oct 28 '19 11:10 NoriSte

awesome plugin! works like a charm :)

I just started using this and noticed that the typescript doesn't seem to be working when the waituntil() is hanging immediately off of cy ?

image

SteveSchreiner avatar Nov 11 '19 20:11 SteveSchreiner

HI @SteveSchreiner, thank you 😊 Could you share the TypeScript error, please? And, if possible, a repo containing just the ts-config file for Cypress and the mentioned test code?

NoriSte avatar Nov 11 '19 21:11 NoriSte

The #66 could have been prevented by converting all the tests to TypeScript.

NoriSte avatar Dec 12 '19 08:12 NoriSte

Cypress released 4.4.0 version including first-class TypeScript support.

NoriSte avatar May 04 '20 06:05 NoriSte