github-issue-reactions-browser-extension icon indicating copy to clipboard operation
github-issue-reactions-browser-extension copied to clipboard

Scroll support?

Open saiworksandbox opened this issue 2 years ago • 6 comments

When there are a lot of reactions the list view gets cut off. And the rest can be viewed only at the bottom of the page. Screenshot (2) It would be great if we could scroll through this. Thank you for such a useful extension 👌

saiworksandbox avatar Jul 14 '23 07:07 saiworksandbox

The problem is that it is "sticky" and I'm wondering if you would be better off with a filter/threshold (top x most rated reactions)?

Norfeldt avatar Jul 17 '23 19:07 Norfeldt

what are your thoughts on having pages? with arrow icons for navigation. Often times I find myself looking for reactions (even if few) on the bottom of the page as that's where the latest info is. Filtering is certainly a cleaner solution though.

saiworksandbox avatar Jul 18 '23 10:07 saiworksandbox

I never personally had the problem. If I did then I would just toggle the layout from block(s) to inline.

Jul-19-2023 20-36-24

I'm not saying that it not a real problem. I want to find the correct solution to the problem before jumping into the code.

Norfeldt avatar Jul 19 '23 18:07 Norfeldt

a hack would be update the .reaction-wrapper to include:

height: 85vh;
overflow: auto;

It just feels like it messes with the page scroll since it common to place your cursor above the reactions and start scrolling.

Norfeldt avatar Jul 19 '23 20:07 Norfeldt

Its certainly an edge case when even the inline mode gets cut off. Maybe a toggle to reverse the order of the reactions? so that reactions on the latest comments show up first?

saiworksandbox avatar Jul 20 '23 04:07 saiworksandbox

Or have a toggle for the position: sticky 😉

I suggest you either make a PR. Otherwise I will wait to see if this issue gets some 👍 from other users and then make the feature.

Norfeldt avatar Jul 20 '23 07:07 Norfeldt