Refactoring and stability

[LionelJouin]

1. NSM

• [ ] Refactor /pkg/client to use NSM APIs (so with context.WithTimeout)
• [ ] Refactor /pkg/nsm
• [ ] Refactor or remove /pkg/nse
• [ ] Replace InterfaceMonitor
• [ ] Split NSM pkg and Spire (Spire pkg to be used in Meridio with the IPAM/NSP APIs)

2. Load balancer

• [ ] NewSimpleNetworkService to a new proper conduit handler struct

3. Ambassador

• [x] Replace config watcher with the NSP API
• [x] Rename target by Ambassador (pkg, cmd, container (Docker, CI, Helm))

4. Proxy

• [x] Multi conduit support to be able to use any conduit name (currently conduit name is static since it is a env variable in the conduit)
• [x] Replace config watcher with the NSP API

5. Internal APIs (IPAM, NSP, Ambassador)

• [ ] Usage of context.WithTimeout
• [ ] #147

6. IPAM

• [x] API re-work + versioning?
• [x] Replace dependency (metal-stack/go-ipam)

7. /pkg/networking

• [ ] re-work interfaces

8. configuration (env variables)

• [ ] replace NSM prefix with MERIDIO
• [ ] replace dependency?

9. Move all example in a single directly (/examples/target)

• [x] New go module
• [x] /cmd/ctraffic ; /build/ctraffic ; /test/applications -> /examples/target

10. other

• [x] recover mechanism on container restart
• [x] keep alive mechanism (target registered but still alive?, proxy releasing subnets to IPAM...)
• [ ] check goroutine leaks
• [ ] drain channels if event sent multiple times
• [ ] modify linters enabled
• [ ] Duplicated VIP addresses (if 2 VIPs have the same address, it could cause issue when they are added/deleted in the lo interface in the target pod) https://github.com/Nordix/Meridio/issues/153

10. NSP

• [ ] Verify Validity of properties in configmap (addresses, ports...) https://github.com/Nordix/Meridio/issues/153
  • [ ] Prevent duplicates VIP addresses