Kotlin-BLE-Library icon indicating copy to clipboard operation
Kotlin-BLE-Library copied to clipboard

Update the library to SLF4J 2.0

Open LionZXY opened this issue 9 months ago • 1 comments

Background

Right now the library is using <2 version of slf4j. This seems wrong to me, as the current version of slf4j is > 2.0.

So I have two questions:

  • Why decided to use slf4j instead of the past self-described logging system?
  • What to do with the abandoned slf4j-timber project that prevents me from upgrading to slf4j 2.0? I created a PR to upgrade slf4j-timber to 2.0, but I'm afraid the author has already abandoned the project. Would you agree to use fork?

LionZXY avatar May 01 '24 10:05 LionZXY

Hello,

If you'd release an updated version of SLF4J-Timber with updated SLF4J version, that would be amazing. I can migrate to use the latest version, but please also release it on Maven Central.

Why decided to use slf4j instead of the past self-described logging system?

We decided not to reinvent the wheel and use something already existing with more features. Also, I had to fix dependency issues and uncouple BLEK from the Nordic Common library, which should in theory only be used for our sample apps, without forcing people to use it, actually, if that's not required.

We've been already using SLF4J in nRF Connect Device Manager app and I liked how easily can be integrated with Timber or even released as non-android library.

philips77 avatar May 03 '24 08:05 philips77