IOS-Nordic-Thingy icon indicating copy to clipboard operation
IOS-Nordic-Thingy copied to clipboard

Published 20 hours ago • verified publisher icon NordicSemiconductor

Fix for building on XCode 13

Open joshkopecek opened this issue 3 years ago • 5 comments

This commit deals with Apple's update which makes the peripheral on CBService optional .

It requires the update on the develop branch of IOS-DFU-Library to be pushed to cocoapods, and will require the dependency version of this library's podspec being updated to match it. The PR has already been merged, but the update hasn't been released on DFU > https://github.com/NordicSemiconductor/IOS-DFU-Library/pull/455

joshkopecek avatar Sep 29 '21 12:09 joshkopecek

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 29 '21 12:09 CLAassistant

The IOS-DFU-Library has been updated to work with Xcode 13, and this PR now builds fine. Might be good to fix the podspec dep to 4.11.1 though?

joshkopecek avatar Nov 01 '21 14:11 joshkopecek

@mostafaberg @philips77 this is the last piece in the puzzle for getting an app to build on Xcode 13. Do you have a timeline for reviewing this? Apologies if you are already considering it, didn't want to hassle you!

joshkopecek avatar Nov 02 '21 12:11 joshkopecek

Hello, we're in a process of updating all our libraries due to xcode 13 changes and Android 12. I'll try to release a new version this week :)

philips77 avatar Nov 02 '21 19:11 philips77

Your PR breaks compatibility with older versions of xcode. Have a look at https://github.com/NordicSemiconductor/IOS-DFU-Library/pull/455

philips77 avatar Nov 02 '21 19:11 philips77