leapp icon indicating copy to clipboard operation
leapp copied to clipboard

Increase/make configurable AWS Console session duration

Open yafanasiev opened this issue 2 years ago • 3 comments

First of all, thanks for a great product! It is a lifesaver and works great with AWS CLI and local SDK. However, while it is awesome you can launch AWS Console straight out of Leapp, the session timeout of one hour makes for a lot of frustration when actively working with console.

I am not quite sure if it is possible to just create the longest possible session, if it is not then maybe a way to override the one hour default somehow.

We can just use the AWS Console session from AWS SSO dashboard, but it would be so much more convenient to do it from Leapp.

I believe the session duration is hard-coded here: https://github.com/Noovolari/leapp/blob/86b5eed3ee65e0cd4bcc7dae67d099199a1b9cf0/packages/core/src/services/web-console-service.ts#L7

yafanasiev avatar Jun 01 '22 19:06 yafanasiev

Thanks for pointing it out!

Yeah, I think we can discuss it in a dedicated PR to discuss the pros and cons of changing this duration.

The line code you are pointing it out is the correct place to change this behavior.

andreacavagna01 avatar Jun 08 '22 10:06 andreacavagna01

Related PR https://github.com/Noovolari/leapp/pull/219

nitrocode avatar Jun 19 '22 14:06 nitrocode

PR #319 created for this feature request.

Should I create the feature to set session duration as described in #219 as well?

I'm also thinking that these settings could be configured in the integration settings as well. If users want to set a session duration/webconsole timeout that differs from the default.

Let me know what you think.

RaviBri avatar Aug 12 '22 16:08 RaviBri