Benedikt Straub

Results 113 comments of Benedikt Straub

Hi, have a look at `src/ui_fsmenu/loadgame.*`, which is the wrapper around a game or replay loading display, and `src/wui/load_or_save_game.*`, which implements the generic UI for saving and loading all kinds...

This is not trivial. I keep getting `heap-use-after-free`s because the random match generation bypasses the default load order. Let's only add a hint for now that world-, tribes-, and script-and...

Now this looks like a veeery interesting situation which is most likely a bug. I thought I had fixed that one for v1.0 in #4037, but this kind of situation...

Is this another case like #5501, where you add a huge number of soldiers via scripting? Whatever there is at coordinate 463x75 (some warehouse I assume), it contains several thousands...

The attack range is hardcoded as 25 fields: https://github.com/widelands/widelands/blob/9adf7c59f4636fb9acda2067aa4dbef6d64d9373/src/logic/player.cc#L1232-L1234 And a radius of 100 *is* pretty excessive ;)

`flag.get_position()` – Paths starts at the enemy building's base flag. `25` – Path may be a maximum of 25 nodes long. `CheckStepDefault(MOVECAPS_WALK)` – Paths are computed as normal walking distance...

We already have Random options for the world and the terrain distribution. What needs to be specified explicitly are map size, number of players, resource amount (low/medium/high), island mode (on/off)....

Bug in attack window saveloading code: ```gdb [00:00:23.947 real] INFO: Game: Reading Interactive Player Data ... widelands: .../src/wui/attack_window.cc:501: void AttackWindow::ListOfSoldiers::remove(const Widelands::Soldier*): Assertion `it != soldiers_.end()' failed. Thread 1 "widelands" received...

Hi and thanks for the patch :) I tested it and it turns out 30000 is still too much; 15000 also crashes; 10000 seems to work. Code suggestion: you could...

It's not a workaround, it's an inherent limitation. You can't have more than a few thousand seeing objects on a node because their amount will overflow a variable. Making the...