aredis icon indicating copy to clipboard operation
aredis copied to clipboard

Don't open connection with loop for python 3.10

Open mdczaplicki opened this issue 4 years ago • 4 comments

Description

Make aredis not pass loop to asyncio function that don't accept it anymore.

https://docs.python.org/3.10/library/asyncio-stream.html#asyncio.open_connection https://docs.python.org/3.10/library/asyncio-stream.html#asyncio.open_unix_connection

https://github.com/NoneGG/aredis/issues/207

mdczaplicki avatar Nov 15 '21 08:11 mdczaplicki

PR is alive? @NoneGG could you please check? Python 3.10 is stable now, but aredis is the showstopper... :(

alvassin avatar Dec 24 '21 21:12 alvassin

@alvassin / @mdczaplicki if you're interested I've forked this repo to https://github.com/alisaifee/coredis and this change is available in [email protected]

alisaifee avatar Jan 05 '22 23:01 alisaifee

Maintainer @NoneGG , merging this PR is required for aredis to work at all on Python 3.10. If you're available, a merge & release to PyPI would be greatly appreciated.


In the meantime, I note that NoneGG has zero commit activity on GitHub since Oct 2020 (about 1.5 years ago)...

Are there any other maintainers for this project?

davidfstr avatar Jul 07 '22 22:07 davidfstr

Are there any other maintainers for this project?

@davidfstr coredis (which was forked from aredis) is being actively developed and works with Python 3.10. There are some details about the divergence and backward compatibility here

alisaifee avatar Jul 07 '22 22:07 alisaifee