aredis Bad connections pool implemetation

I've found multiple problems with current pool implementation:

Pool is blocking. There is no async initialization which leads to next problems,
There is no way to set minimum number of connections that are created at pool initialization.
Instead of asyncronously blocking until connection is available, pool will raise exception: https://github.com/NoneGG/aredis/blob/cec3cdabe67f45493ac413737d8579f46c27fded/aredis/pool.py#L225-L226 This makes any command invocation unsafe and requires user to do error handling. Current behaviour could be preserved with option though. Addressing these issues will mean making backwards-incompatible changes (making get_connection async at least).

Some examples of pool implementations that could be referenced:

https://github.com/MagicStack/asyncpg/blob/master/asyncpg/pool.py
https://github.com/aio-libs/aioredis/blob/master/aioredis/pool.py

Aug 15 '20 10:08 Fogapod

Thats affects me, too. It's very disappointing.

Aug 20 '20 17:08 kiselev-nikolay

I emailed @NoneGG asking about a possibility of releasing 2.0.0 with a few breaking changes addressing pool implementation and other issues

Aug 20 '20 17:08 Fogapod

I emailed @NoneGG asking about a possibility of releasing 2.0.0 with a few breaking changes addressing pool implementation and other issues

May I know when version 2.0.0 is released?

Aug 26 '20 03:08 ducminhgd

May I know when version 2.0.0 is released?

I haven't got a response from maintainer yet, there haven't been any work on 2.0.0 so far.

Aug 26 '20 08:08 Fogapod

Thanks for your efforts @Fogapod. I think there will be many new users here, since aioredis seems to have been abandoned. Let's hope this project can become a good replacement.

Aug 26 '20 09:08 mjwestcott

@Fogapod Aren't responses from the maintainer yet? I really want to use aredis on my big projects.

Oct 13 '20 17:10 drgarcia1986

@drgarcia1986 unfortunately, no. And I don't think I have time to work on aredis at this point.

Oct 14 '20 07:10 Fogapod

@Fogapod maybe if @NoneGG add more maintainers, we can work together to fix bugs and rethink the connection pool design

Oct 14 '20 12:10 drgarcia1986

We just hit this in production too:

https://gitlab.com/fluidattacks/product/-/issues/3874

I'm willing to contribute a patch, but I'll need a hand with the desired interface/implementation, at least a skeleton or a few words. This in order to keep the library useful to the most people as possible and not break too much compatibility

Dec 29 '20 17:12 kamadorueda