hardhat icon indicating copy to clipboard operation
hardhat copied to clipboard

Add a guide for using the create2 strategy

Open zoeyTM opened this issue 1 year ago • 3 comments
trafficstars

resolves https://github.com/NomicFoundation/hardhat-ignition/issues/670

depends on https://github.com/NomicFoundation/hardhat-ignition/pull/626

zoeyTM avatar Jan 12 '24 06:01 zoeyTM

⚠️ No Changeset found

Latest commit: f1b4f2cb1a6c057f88acd24e1d25f33d9a23a36a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 12 '24 06:01 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 0:06am

vercel[bot] avatar Jan 12 '24 06:01 vercel[bot]

We should update this in light of our create2 config changes.

kanej avatar Feb 16 '24 20:02 kanej

I think there are too many ":::tip" here, it doesn't look good when rendered.

Some proposed changes:

  • Remove all the tips
  • Add a section at the top, explaining what CreateX, explaining its security considerations (just like the current tip), and linking to its docs. Basically replacing the CreateX-related tips with a section.

WDYT @zoeyTM ?

alcuadrado avatar Mar 05 '24 21:03 alcuadrado

@alcuadrado I would really like to keep the one note about security considerations, so I ended up only adding that one CreateX tip at the very top of the page, and deleting the others. Let me know what you think; I'm happy to remove it and/or the one regarding the quick start guide if you still want to.

zoeyTM avatar Mar 07 '24 06:03 zoeyTM