hardhat icon indicating copy to clipboard operation
hardhat copied to clipboard

fix: support for both input or data field in rpcCallRequest

Open lsheva opened this issue 1 year ago • 4 comments

Issue: go-ethereum from version 13.0 stopped working with local hardhat node. They did a change replacing data to input field in eth_call and other methods https://github.com/ethereum/go-ethereum/pull/28078 referencing Ethereum specification

Update: replaces rpcCallRequest to use input field instead of data. Fallbacks to data if input not set for backward compatibility.

lsheva avatar Oct 04 '23 19:10 lsheva

⚠️ No Changeset found

Latest commit: 37a20b9340f595b2f5fb5e43cd85deb7c7173e73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 04 '23 19:10 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 7:46pm
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 7:46pm

vercel[bot] avatar Oct 04 '23 19:10 vercel[bot]

keeping an eye on this as its blocking usage of geth v1.13+ with hardhat

marlon-wiprud avatar Dec 06 '23 13:12 marlon-wiprud

What needs to be done for this to get merged? I spent half a day figuring out why my eth_calls were working fine against goerli nodes, but not against hardhat. Iit turns out that web3js by default uses input and I was ending with unrecognized selectors.

@fvictorio

compojoom avatar Dec 15 '23 08:12 compojoom