hardhat icon indicating copy to clipboard operation
hardhat copied to clipboard

Add support for Celoscan

Open therealharpaljadeja opened this issue 2 years ago • 5 comments

  • [ ] Because this PR includes a bug fix, relevant tests have been included.
  • [x] Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team. --> #2932
  • [ ] I didn't do anything of this.

What does this PR introduce?

Add support for Celo and Alfajores network, by adding the Celo and Alfajores chain specifications underChainConfig.ts.

This is to enable to verify contracts deployed on Celo via the command:

npx hardhat verify --network celo

therealharpaljadeja avatar Jul 12 '22 15:07 therealharpaljadeja

⚠️ No Changeset found

Latest commit: 34f2002812900d42c7ba5e146c912e12294980a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 12 '22 15:07 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hardhat ✅ Ready (Inspect) Visit Preview Jul 12, 2022 at 3:28PM (UTC)
hardhat-storybook ✅ Ready (Inspect) Visit Preview Jul 12, 2022 at 3:28PM (UTC)

vercel[bot] avatar Jul 12 '22 15:07 vercel[bot]

This issue is also being tracked on Linear.

We use Linear to manage our development process, but we keep the conversations on Github.

LINEAR-ID: 9e9642bd-8c5a-4782-8f6d-2984867170ae

github-actions[bot] avatar Jul 12 '22 15:07 github-actions[bot]

Thanks for submitting this PR!

Unfortunately, it has some linter errors, so we can't merge it yet. Can you please fix them?

Running yarn lint:fix in the root of the repository may fix them automatically.

github-actions[bot] avatar Jul 12 '22 15:07 github-actions[bot]

Fixes #2924

therealharpaljadeja avatar Jul 13 '22 15:07 therealharpaljadeja

@therealharpaljadeja @alcuadrado Im a bit confused here. how adding the network info have fixed the issue here?

I'm actually experiening the same issue:

The HTTP server response is not ok. Status code: 400 Response text: {"message":"Unknown action","result":null,"status":"0"}

The network is using bloclscout also, and API endpoint is https://esc-testnet.elastos.io/api

Would be great to have some insights

irzhywau avatar Feb 15 '23 16:02 irzhywau

In general we are not adding new networks to hardhat-verify. Users can do it manually (check this to learn how) and that can be easily packaged in a community plugin.

fvictorio avatar Nov 07 '23 10:11 fvictorio