hardhat
hardhat copied to clipboard
NomicFoundation
Remove gas field from abi
- [x] Because this PR includes a bug fix, relevant tests have been included.
Earlier Versions of Vyper generate a gas field in the ABI. This gas estimate is often incorrect and produces invalid typechain objects (see https://github.com/NomicFoundation/hardhat/issues/1696, https://github.com/dethcrypto/TypeChain/pull/711)
⚠️ No Changeset found
Latest commit: 7f11ecc0c741bccde3d5e661694aed0dc469c476
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| hardhat | ✅ Ready (Inspect) | Visit Preview | Jun 24, 2022 at 2:14PM (UTC) |
| hardhat-storybook | ✅ Ready (Inspect) | Visit Preview | Jun 24, 2022 at 2:14PM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue is also being tracked on Linear.
We use Linear to manage our development process, but we keep the conversations on Github.
LINEAR-ID: 843e7cc1-04ee-4e9c-a5a5-996a42a853a5
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @MarkuSchick , great to see progress on this - is there a timeline for when we can get this reviewed?
Woohoo, your important contribution to this open-source project has earned you a GitPOAP!
GitPOAP: 2022 Hardhat Contributor:
Head on over to GitPOAP.io and connect your GitHub account to mint!
![gitpoap-bot[bot] avatar](https://avatars.githubusercontent.com/in/209535?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @MarkuSchick, @feuGeneA -- can we get a new hardhat-vyper release pushed to npm given this fix?
Much appreciated!
@fvictorio Please release new version of @nomiclabs/hardhat-vyper so this fix gets included in the package.
@avele we forgot to include a changeset for this change, so this wasn't included in our latest release. I will create one now, so that this is published the next time we make a release.
