hardhat icon indicating copy to clipboard operation
hardhat copied to clipboard

Add ethers.getContractAt validation that the given address is actually a contract

Open derawi opened this issue 2 years ago • 6 comments

Working on issue: https://github.com/NomicFoundation/hardhat/issues/2170

Included a test

derawi avatar May 04 '22 06:05 derawi

⚠️ No Changeset found

Latest commit: 3dde1cfe38c6d7d4cf9d7d04c9e9d22d10ecf40d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 04 '22 06:05 changeset-bot[bot]

This PR was marked as stale because it didn't have any activity in the last 30 days. Please excuse us if we didn't have enough time to review it and get it merged. If you are still interested in getting these changes applied, please leave a comment indicating so. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar Jun 03 '22 07:06 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Jun 10 '22 07:06 github-actions[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hardhat ❌ Failed (Inspect) Jun 10, 2022 at 11:00AM (UTC)
hardhat-storybook ❌ Failed (Inspect) Jun 10, 2022 at 11:00AM (UTC)

vercel[bot] avatar Jun 10 '22 10:06 vercel[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Jun 17 '22 11:06 github-actions[bot]

This bot is way too agressive!

alcuadrado avatar Jun 17 '22 11:06 alcuadrado

Hey @derawi, sorry for not responding before.

We had this validation at some point and then we removed it because it broke smock, so I don't think we'll include it again for the time being.

Thanks and sorry again for not responding sooner!

fvictorio avatar Nov 16 '22 17:11 fvictorio