advanced-ts: fix eslint plugin breaking ts imports

[the-vampiire]

• [ ] Because this PR includes a bug fix, relevant tests have been included.
• [ ] Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
• [x] I didn't do anything of this.

---

fixes https://github.com/NomicFoundation/hardhat/issues/2266

in the typescript starter it is using plugin:node/recommended for eslint which breaks every import done across files (see linked issue). this is strange considering typescript projects are already installing the ts-eslint rules.

some in the thread suggested removing the rules entirely but i have found that replacing them with the @typescript-eslint/recommended is a drop-in replacement.

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: 64f478fcd9a77ba2290bc93ea7f605a1eefe0f92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[the-vampiire]

in addition i recommend adding https://www.npmjs.com/package/eslint-plugin-chai-friendly

this will prevent the "no unused expressions" for things like .to.be.true

[github-actions[bot]]

This PR was marked as stale because it didn't have any activity in the last 30 days. Please excuse us if we didn't have enough time to review it and get it merged. If you are still interested in getting these changes applied, please leave a comment indicating so. Otherwise, it will be closed in 7 days.

[the-vampiire]

i still think this is worth considering. easy PR to merge - only changes a dev dep. improves devx

[github-actions[bot]]

This PR was marked as stale because it didn't have any activity in the last 30 days. Please excuse us if we didn't have enough time to review it and get it merged. If you are still interested in getting these changes applied, please leave a comment indicating so. Otherwise, it will be closed in 7 days.

[fvictorio]

Hey @the-vampiire, since you sent this PR we've changed our sample projects. They no longer include an eslint config, that's why there are merge conflicts here.

Since no having eslint anymore makes the problem pointed by you no longer relevant, I'm going to close this PR. Thanks a lot for sending it and sorry for not responding sooner!