hardhat
hardhat copied to clipboard
NomicFoundation
Minimally patch the viaIR issue for running unit tests
This minimally patches the viaIR issue for a particular case where we are encountering it.
I believe this is also addresses the cause of #2115.
⚠️ No Changeset found
Latest commit: c4914b5bdc41eb74a93569454e132c157ab36560
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR was marked as stale because it didn't have any activity in the last 30 days. Please excuse us if we didn't have enough time to review it and get it merged. If you are still interested in getting these changes applied, please leave a comment indicating so. Otherwise, it will be closed in 7 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR was marked as stale because it didn't have any activity in the last 30 days. Please excuse us if we didn't have enough time to review it and get it merged. If you are still interested in getting these changes applied, please leave a comment indicating so. Otherwise, it will be closed in 7 days.
Please don't close until fixed!
This PR was marked as stale because it didn't have any activity in the last 30 days. Please excuse us if we didn't have enough time to review it and get it merged. If you are still interested in getting these changes applied, please leave a comment indicating so. Otherwise, it will be closed in 7 days.
This PR was marked as stale because it didn't have any activity in the last 30 days. Please excuse us if we didn't have enough time to review it and get it merged. If you are still interested in getting these changes applied, please leave a comment indicating so. Otherwise, it will be closed in 7 days.
Please don't close until fixed!
This PR was marked as stale because it didn't have any activity in the last 30 days. Please excuse us if we didn't have enough time to review it and get it merged. If you are still interested in getting these changes applied, please leave a comment indicating so. Otherwise, it will be closed in 7 days.
This PR was marked as stale because it didn't have any activity in the last 30 days. Please excuse us if we didn't have enough time to review it and get it merged. If you are still interested in getting these changes applied, please leave a comment indicating so. Otherwise, it will be closed in 7 days.
Please don't close until fixed!
Any reason NOT to merge this issue? while it doesn't "fix" the stack trace, at least it makes normal revert-to-error mapping works correctly and not break tests needlessly, and show the proper revert reason. I came up with the exact same problem (failed unittest) and almost exact same workaround...
Hey guys, I'm very sorry for not merging this sooner. I believe this will be fixed (at least partially) by https://github.com/NomicFoundation/hardhat/pull/3205, so I'm going to close this one. I hope we can release that change in the coming weeks and I'll try to remember to let you know here when it's released.
