hardhat icon indicating copy to clipboard operation
hardhat copied to clipboard

Published 20 hours ago • verified publisher icon NomicFoundation

Support chains that don't include a totalDifficulty block field

Open tinybike opened this issue 3 years ago • 7 comments

  • [x] Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.

Resolves nomiclabs/hardhat#2106. Wanted to go ahead and send in the PR while I was thinking of it, but I'm not sure this belongs in hardhat proper. If you guys don't think so please feel free to just close.

tinybike avatar Jan 29 '22 19:01 tinybike

⚠️ No Changeset found

Latest commit: 5b73bd270da6d8e31abf5af4bf380c2b19d3ebe2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 29 '22 19:01 changeset-bot[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 29 '22 19:01 CLAassistant

This PR was marked as stale because it didn't have any activity in the last 30 days. Please excuse us if we didn't have enough time to review it and get it merged. If you are still interested in getting these changes applied, please leave a comment indicating so. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar May 14 '22 18:05 github-actions[bot]

It's 100% up to you guys. If you feel like this belongs in hardhat, sure, go for it. Otherwise, feel free to close it.

tinybike avatar May 17 '22 00:05 tinybike

This PR was marked as stale because it didn't have any activity in the last 30 days. Please excuse us if we didn't have enough time to review it and get it merged. If you are still interested in getting these changes applied, please leave a comment indicating so. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar Jun 16 '22 00:06 github-actions[bot]

Hey @tinybike! Sorry for the delay. I'll review this next week, once our next version is out.

alcuadrado avatar Jun 16 '22 17:06 alcuadrado

+1 trying to run moonbeam/moonriver on hardhat and need this fix

misterjame avatar Aug 09 '22 05:08 misterjame

+1. In the meantime, any suggested workaround?

yaojiach avatar Sep 26 '22 07:09 yaojiach

Hi @alcuadrado is this still in the pipeline?

timbrinded avatar Oct 19 '22 14:10 timbrinded

Hi folks, sorry for the (very, very) late response.

I think the way to go here is to close this PR and open a new issue with this feature request, to discuss potential approaches and to gauge how much interest there is on this. The current implementation is a bit too hackish, so it's unlikely that we'll merge it. And since this is an old PR, I'd rather start over here.

I know that it sucks to get a response many months later just to get the PR closed, sorry again about that :disappointed:

fvictorio avatar Nov 16 '22 17:11 fvictorio

No worries @fvictorio, yes this was hackish af, I'm not surprised you don't want this silliness in hardhat proper haha

tinybike avatar Dec 25 '22 21:12 tinybike