hardhat icon indicating copy to clipboard operation
hardhat copied to clipboard

Give Waffle runtime augment its own interface

Open flux627 opened this issue 4 years ago • 3 comments

  • [ ] (If this PR includes a documentation change) This PR's branch was created from the website branch, and this PR uses the website branch as its base branch.
  • [ ] (If this PR includes a bug fix) Relevant tests have been included.
  • [ ] (If this PR includes a new feature) The change was previously discussed on an Issue or with someone from the team.
  • [x] I didn't do anything of this.

Re: NomicFoundation/hardhat-waffle#3

This change allows projects like TypeChain to augment Hardhat's Waffle integration (specifically, overloading deployContract for type support). Should have no other consequence.

flux627 avatar Jul 24 '21 20:07 flux627

Thanks for sending this PR!

I only left a minor comment.

alcuadrado avatar Aug 13 '21 15:08 alcuadrado

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 04 '21 12:11 CLAassistant

This PR was marked as stale because it didn't have any activity in the last 30 days. Please excuse us if we didn't have enough time to review it and get it merged. If you are still interested in getting these changes applied, please leave a comment indicating so. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar Aug 06 '22 21:08 github-actions[bot]

Hey @flux627, sorry for closing this, but we are moving hardhat-waffle to another repository. If you want, you could rebase this change there, although I would understand if you no longer care about this change after all this time :sweat_smile:.

fvictorio avatar Sep 28 '22 10:09 fvictorio