hardhat-vscode icon indicating copy to clipboard operation
hardhat-vscode copied to clipboard

[Feature] Go To Definition does not work or is not fully resolved

Open DrakeEvans opened this issue 10 months ago • 5 comments

Feature: Go To Definition should support function definitions as well as fully resolve Definitions

Current Situation: Function definitions not supported, For supported symbols Go To Definition only goes to the nearest declaration not to the implementation

https://github.com/NomicFoundation/hardhat-vscode/assets/31104161/67496b24-9d93-4ea3-97ae-ecf30fd41b18

Proposed: Function definitions supported, Go To Definition fully resolves to implementation not nearest declaration

https://github.com/NomicFoundation/hardhat-vscode/assets/31104161/bf6ba5e8-30c1-4ae2-896d-a1fbfd3a0e72

DrakeEvans avatar Apr 12 '24 18:04 DrakeEvans

The OptimalOutcome.mp4 is generated from using the Tools For Solidity extension

DrakeEvans avatar Apr 12 '24 18:04 DrakeEvans

Hey @DrakeEvans, thanks for the reproduction videos they are always valued. Can you point me to to the repo you where using if its open source?

kanej avatar Apr 15 '24 09:04 kanej

@kanej Yes you can see it at https://github.com/agora-finance/agora-dollar-evm-tests/blob/master/src/test/erc20-privilaged/TestMinting.t.sol

You will need to run forge install and npm i to make it work

DrakeEvans avatar Apr 18 '24 04:04 DrakeEvans

Will need to run npm i inside of one submodule as well cd lib/agora-dollar-evm/ && npm i

DrakeEvans avatar Apr 18 '24 04:04 DrakeEvans