hardhat-ignition icon indicating copy to clipboard operation
hardhat-ignition copied to clipboard

Module parameters defined in Module Parameters

Open kanej opened this issue 1 year ago • 1 comments

This is an investigation task.

Passing module parameters at the command line as a JSON file has issues. For instance, BigInts are not natively supported in JSON (see https://github.com/NomicFoundation/hardhat-ignition/issues/663). We are forced to provide our own custom deserialization.

This opens several questions we want to investigate:

  • Can we support the use cases where a module parameters file is used via the Hardhat.config.{js,ts} file? Should we?
  • Would this lead to deprecation of the module parameters JSON file or some other approach?
  • How can we minimize adding pain for Foundry users wanting to leverage Ignition?

See the Nomic design doc for the BigInt discussion: https://www.notion.so/nomicfoundation/Module-parameters-file-c492f88afd1847218de9f0de693a2f72?pvs=4

kanej avatar Feb 07 '24 10:02 kanej

The intention here is revisit our module parameter file usage in the run into HH v3.

kanej avatar Feb 15 '24 11:02 kanej