hardhat-boilerplate icon indicating copy to clipboard operation
hardhat-boilerplate copied to clipboard

Convert to React Hooks

Open wilrho opened this issue 3 years ago • 7 comments

Hi it would be nice for the boilerplate to be using hooks instead, I have done a quick conversion if you like accept the PR?

wilrho avatar Jul 21 '21 12:07 wilrho

To be honest I'm not sure if that's the right move. Aren't class-based components more widely understand than hooks?

Hooks are cool, but the more people understands this project, the better.

alcuadrado avatar Jul 22 '21 13:07 alcuadrado

No worries just an offer, imho most of the react devs have moved over to hooks, but anyways up to you 🙂

Get Outlook for iOShttps://aka.ms/o0ukef


From: Patricio Palladino @.> Sent: Thursday, July 22, 2021 11:45:21 PM To: nomiclabs/hardhat-hackathon-boilerplate @.> Cc: WilHo_AI @.>; Author @.> Subject: Re: [nomiclabs/hardhat-hackathon-boilerplate] Convert to React Hooks (#26)

To be honest I'm not sure if that's the right move. Aren't class-based components more widely understand than hooks?

Hooks are cool, but the more people understands this project, the better.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnomiclabs%2Fhardhat-hackathon-boilerplate%2Fissues%2F26%23issuecomment-884924622&data=04%7C01%7C%7Cf635359dc224409c39bd08d94d16f415%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637625583247593192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2BFSzqKqST51HDp%2BBN0YCrOBh%2BCmdfCFS4pMNlrCZWMU%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGNRVLBW7RODAIPBQ5VJZWTTZAOHDANCNFSM5AX3SROA&data=04%7C01%7C%7Cf635359dc224409c39bd08d94d16f415%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637625583247598170%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=GquECT%2BOuct1XWJa2jvVQPZUCRcZO0rNqy9A2TzAtdc%3D&reserved=0.

wilrho avatar Jul 22 '21 14:07 wilrho

Truly as a beginner preferring functional components.. which make life a bit easier.

ws30001173 avatar Nov 22 '21 08:11 ws30001173

Functional components are new standard and much easier to understand and use, I was supprised to see this boilerplate use class components.

@wilrho please share a fork of conversion, would rather use that then, thnx

0xCardinalError avatar Feb 17 '22 16:02 0xCardinalError

To be honest I'm not sure if that's the right move. Aren't class-based components more widely understand than hooks?

Hooks are cool, but the more people understands this project, the better.

I recently figured out that react is migrating its docs to hooks, so maybe it's time to reconsider this

alcuadrado avatar Feb 17 '22 17:02 alcuadrado

Note: We just released an overhaul of this repo, but the frontend/ is mostly the same. If someone wants to migrate it to react hooks, please let us know.

alcuadrado avatar Jul 08 '22 13:07 alcuadrado

Hello, I migrated my own project based on the boilerplate to React Hooks and would be happy to make a PR.

ashtron avatar Aug 01 '22 23:08 ashtron