edr icon indicating copy to clipboard operation
edr copied to clipboard

Adopt alloy types for transaction types

Open Wodann opened this issue 9 months ago • 3 comments

While working on https://github.com/NomicFoundation/edr/issues/786, I investigated using alloy-rs's TxEip7702 type, but wasn't able to use those types side-by-side with our existing transaction types.

TxEip7702 would be equivalent to our transaction::request::Eip7702. To obtain a signed transaction, alloy uses Signed<TxEip7702>, which adds pre-computation of a tranaction_hash, RLP encoding/decoding, etc.

One aspect of EDR that wasn't easily transferred to types from alloy was the ability to have a "fakeable signature" which we support.

Definition of Done Investigate and refactor transaction types to reuse alloy types and tests

Wodann avatar Feb 11 '25 21:02 Wodann

@Wodann does this issue point to refactoring all the existing transaction types and not only Eip7702?

AmosAidoo avatar Mar 24 '25 10:03 AmosAidoo

The path forward is unclear. An investigation should be done as to whether we can upgrade to alloy types within our architecture, without losing support for fakeable signatures. Only after that will the refactor happen.

Wodann avatar Mar 24 '25 15:03 Wodann

Okay, makes sense 👍🏽

AmosAidoo avatar Mar 24 '25 15:03 AmosAidoo