edr icon indicating copy to clipboard operation
edr copied to clipboard

Published 20 hours ago • verified publisher icon NomicFoundation

Rename abbreviated generic variables

Open Wodann opened this issue 2 years ago • 2 comments

Currently, we're using abbreviated generic type names, such as BE for "blockchain error" or SE for "state error". They should be renamed to their full equivalent. Format TBD: TBlockchainError or BLOCKCHAIN_ERROR.

@Wodann will discuss Slang's choice to decide format.

Wodann avatar Jul 31 '23 15:07 Wodann

I'm a big fan of naming these variables as BlockchainErrorT in typescript. The T, obviously, comes from Type.

alcuadrado avatar Jul 31 '23 18:07 alcuadrado

There is a downside to that, being that it's not instantly clear that you're dealing with a generic type, only by noticing the last character T

Wodann avatar Jul 31 '23 21:07 Wodann