Chrome-Store-Foxified icon indicating copy to clipboard operation
Chrome-Store-Foxified copied to clipboard

Randomize signing URL names

Open Madis0 opened this issue 6 years ago • 8 comments

The problem:

  • Every extension needs signing to be used
  • Every signed extension needs an URL name https://addons.mozilla.org/en-US/firefox/addon/_something-written-here_
  • When a bunch of users use and sign Chrome extensions, they steal valuable URL names from developers that may want to port their own Chrome extension, or just provide a similar alternative

The solution:

  • Randomize the URL names, like a password generator
  • Optionally append a prefix CSF to the names to further separate extensions signed by this and "legit" uploaded extensions

What do you think?

Madis0 avatar Nov 05 '17 11:11 Madis0

This is an important one. I forgot to land this. I'll do this before v3 gets out, I was about to release. I'll put in the modal and then this first.

Noitidart avatar Nov 05 '17 19:11 Noitidart

I'm exploring here - https://addons-server.readthedocs.io/en/latest/topics/api/addons.html#detail - i haven't found a way to change the slug yet, still looking. Only way so far is to change addon name to something ugly, but then that will show up with the ugly and non-descriptive name in the addon manager, I think. Would be awesome if you can help me peak into this API.

Noitidart avatar Nov 05 '17 19:11 Noitidart

Isn't that it?

addon-id – The id for the add-on. https://addons-server.readthedocs.io/en/latest/topics/api/signing.html#uploading-a-version

Madis0 avatar Nov 05 '17 19:11 Madis0

It seems that id is not used for the slug. :(

As seen in this screenshot, I prefixed the UUID of "File upload" kind with "generated" but that only becomes the uuid, the slug is taken from the name it seems:

Noitidart avatar Nov 05 '17 19:11 Noitidart

What about randomizing the name on upload but changing it right after? I don't think that name will show up on add-on manager anyway, that should use the one set in manifest.

Madis0 avatar Nov 05 '17 19:11 Madis0

That's realy smart! So do 2x review processes instead of one, on the first one use a random name, then on the second one change it. That's a possibility, its more then a small change to the current flow. :( It might be easier to go to the edit page and figure post to the form (non-rest api style) (web scraping style).

The name in the review is also taken from manifest.

Noitidart avatar Nov 05 '17 20:11 Noitidart

AFAIK the AMO team wants to change this anyway. Only public listed add-ons should get a slug in the future. No idea how fast this will get implemented.

Croydon avatar Nov 06 '17 22:11 Croydon

That is a super helpful comment, if they do that, then I don't have to do anything woohoo haha.

Noitidart avatar Nov 06 '17 22:11 Noitidart