php-spx
php-spx copied to clipboard
NoiseByNorthwest
Open reports in a new tab
This change, will make clicking a report open a new tab or window, instead of opening it in the current.
Is it really better than letting the user choose between opening in the same window (right click) and opening in a new tab (middle click) ?
No, not really. My use case is a bit special, I open the control panel in a iframe - part of a debug panel. So then a click on reports replaces the control panel, but I would rather have it open a new tab open by default. Cause the debug panel is not a fullpage.
It would be nice if its configurable I think.
How do you handle this issue with the other applications embedded via an iframe ? Or maybe php-spx is the sole external interface that you embed with an iframe ?
Its the sole embeded interface which opens new pages.
I agree with u, it is unecessary ' ctrl+click is fine. And I pondered about this since I made the PR, I think I should not open this in the "debug panel", I should just open a new tab. Its cool though to have a link from debug toolbar .. but opening it inside was not a good idea.