php-spx icon indicating copy to clipboard operation
php-spx copied to clipboard

Published 20 hours ago • verified publisher icon NoiseByNorthwest

Add simple search feature

Open ilnytskyi opened this issue 4 years ago • 1 comments

Simple search feature to filter and highlight matched functions. Selection_675 after search Selection_676

ilnytskyi avatar Apr 29 '21 11:04 ilnytskyi

@NoiseByNorthwest I a bit changed this feature. after search

ilnytskyi avatar Oct 06 '21 18:10 ilnytskyi

@ilnytskyi The history of your branch is not very clear with many merges of master. I've fixed the history in https://github.com/NoiseByNorthwest/php-spx/tree/search_feature/fixed_history so that your commits are straight on top of the current master. Could check if it is OK and reset your branch to this ref ?

There are also few commits with Your Name <[email protected]> as author, could you fix it ?

NoiseByNorthwest avatar Oct 09 '22 09:10 NoiseByNorthwest

@NoiseByNorthwest Thanks for review. I created new branch from latest master with all changes in one correctly signed commit.

https://github.com/ilnytskyi/php-spx/commits/search_feature_fixed

I think it can be merged instead of branch from this PR.

ilnytskyi avatar Oct 11 '22 09:10 ilnytskyi

@ilnytskyi Yes, https://github.com/ilnytskyi/php-spx/commits/search_feature_fixed is OK, overwrite this PR or close it and create a new one, I will merge it as soon as it will be green.

NoiseByNorthwest avatar Oct 16 '22 09:10 NoiseByNorthwest

closing this in favour of https://github.com/NoiseByNorthwest/php-spx/pull/202

ilnytskyi avatar Oct 16 '22 10:10 ilnytskyi