Monocle icon indicating copy to clipboard operation
Monocle copied to clipboard

Published 20 hours ago • verified publisher icon Noctem

Send Unown form via webhook

Open evenly-epic-mule opened this issue 7 years ago • 7 comments

evenly-epic-mule avatar Jun 08 '17 14:06 evenly-epic-mule

I have yet to see one! Heh

baskettcase avatar Jun 08 '17 14:06 baskettcase

Should this also be added to db and the frontend? @evenly-epic-mule

tallypokemap avatar Jun 08 '17 15:06 tallypokemap

Has this been successfully tested with PokeAlarm for example? I know PR #250 works for sure but it was using encounter and only sending form to the webhook of Unown only.

RobTwoThree avatar Jun 08 '17 17:06 RobTwoThree

@tallypokemap actually yes, but I'm not sure how at best, because adding a new column for only one Pokemon is kind of a waste of resources

I think we should come up with a draft for some extra details like "XL Karp", "Unown Type", ...

evenly-epic-mule avatar Jun 15 '17 11:06 evenly-epic-mule

@tallypokemap @evenly-epic-mule PGScout branch has implemented Unown form (smallint column). The form gets sent as an INT to PA. PA doesn't convert the INT as of right now.

One column for a pokemon is a bit wasteful. Most values will be inserted as None/Null though.

ghost avatar Jun 15 '17 16:06 ghost

@Avatar690 Actually in brach 3.2 of PA Deadly has put in the capability for

DTS and it does convert the int.

ghost avatar Jun 19 '17 06:06 ghost

@ifindpokemons awesome. Ill have to fix my alarms!

Sent from my LGE LG-H820 using FastHub

ghost avatar Jun 23 '17 20:06 ghost