Monocle
Monocle copied to clipboard
Noctem
Send Unown form notification
Much like gender, pull Unown form and send to notifications. Does not insert form into database and therefore does not display on web.py. Works with PokeAlarm. Successfully tested with PokeAlarm.
Unown forms is availible on WildPokemon. You can do that without encounter.
Updated to check for Unown "form" without requiring encounter and send to webhook. May consider closing this PR since PR #284 does the same thing. The difference is this only sends "form" for Unown. Difficult to test since Unown are ultra rare.
@j16sdiz This may be true, however, the way form is being passed, it still requires it to be encountered. I tried it without encounter and Unown form wasn't being passed to PokeAlarm like it used to.
starnge, i have been running without encounter for a month and still have forms. I have only changed normalize_pokemon and the notifcation.py
@j16sdiz I believe its because there's a bug with ENCOUNTER = None, 'some', 'notify'. When I set ENCOUNTER = 'none' but still have notifications, it doesn't send form to webhook because all encounters are turned off. So I tried ENCOUNTER = 'some' and it still wouldn't send form. Only when I have ENCOUNTER = 'notify' does it send form and all encounter data on all in ALWAYS_NOTIFY_IDS. So we were left with all or none. I was able to patch the ENCOUNTER = 'some' bug and from there I was able to determine that form (and all encounter data) is only sent to webhook during encounter code because only normalized pokemon are sent to webhook which includes the form attribute. Its a bigger bug with what is being sent to webhook, but I think the patch fixes it for now.