NobiGo

Results 31 comments of NobiGo

If no others developer have another comments in this PR. I will merge it in the next days.

Before merge this PR. I think maybe we should reach an agreement in Jira. Because this will be exists confuse in the future.(The code implement is different about the design)

> There are lots of changes in the quoting of identifiers. Is this a bug that is being fixed? If so, can it be a separate PR? Yes,If we don't...

> Can you make a separate issue about quoting then? Too many unrelated changes in this PR. Please check the CALCITE-6434.

> why is this a draft? Hi @mihaibudiu . I have add comment in the JIRA. This SQL can't run as expected in Spark And Hive.

@mihaibudiu Hi, Sorry to bother you. If you have free time, please review this again.

If there are no other comments, I will merge it in the next few days.

> If the problem is indeed in `Values` please add specific tests for this expression and update the JIRA/PR accordingly. @zabetak Hi, It is not a VALUES problem. But When...

> I see that you are performing the changes that we discuss here in another pull request (#3981). This is a bit confusing and I am losing track on where...