Allow a block to be passed to authenticate

Open Fustrate opened this issue 10 years ago • 2 comments

Per the discussion at NoamB/sorcery#698.

Jul 18 '15 22:07 Fustrate

Hi @Fustrate,

thanks a lot for your contribution! I've briefly read the code and it looks good (and thanks for improving specs!). I'll have more time next week to read it once again in detail and then I'll let you know if I'd change anything there.

Answering your question about coding style - it would be great to improve the style. I haven't run rubocop on Sorcery code, but I know it must show lots of issues. I don't agree with some of them - e.g. I do't like enforcing single/double quotes, and I prefer to keep lines up to 100 chars instead of 80, but I'm fine with such changes as well.

Jul 22 '15 12:07 arnvald

Any updates on this?

Nov 25 '15 01:11 Fustrate