uniswap-api icon indicating copy to clipboard operation
uniswap-api copied to clipboard

Finish first version of Uniswap API

Open haydenadams opened this issue 6 years ago • 15 comments

This issue will be assigned to @conlan

Spec: https://docs.google.com/document/d/1-FulegTvr_Mx6vdHbPXdYHg8K4g5zLlYDNFa_ILXQ5Y/edit?usp=sharing

  • [ ] GET /api/v1/directory
  • [x] GET /api/v1/exchange
  • [X] GET /api/v1/price
  • [X] GET /api/v1/ticker
  • [X] GET /api/v1/history
  • [ ] Document API
  • [x] Add to uniswap.info

haydenadams avatar Jan 15 '19 04:01 haydenadams

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 500.0 DAI (500.0 USD @ $1.0/DAI) attached to it as part of the Ethereum Foundation fund.

gitcoinbot avatar Jan 15 '19 16:01 gitcoinbot

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 weeks, 2 days ago. Please review their action plans below:

1) alogishetty has applied to start work (Funders only: approve worker | reject worker).

I will be developing code to create new endpoints and document them on how to use it.

Learn more on the Gitcoin Issue Details page.

2) conlan has been approved to start work.

Hi there! Just signing in here to claim the task.

Learn more on the Gitcoin Issue Details page.

gitcoinbot avatar Jan 15 '19 16:01 gitcoinbot

Hi @haydenadams, As I understand there is the /directory to implement, add docs for all endpoints to https://github.com/Uniswap/docs/blob/master/analytics-api/analytics-api.md and render the data in https://github.com/Uniswap/uniswap-info is that correct? how should it appear in uniswap.info?

alonp99 avatar Jan 15 '19 17:01 alonp99

Hi @alonp99 (and others) thanks for your interest. This issue has been assigned to @conlan - he just need sign in to gitcoin and claim the task

haydenadams avatar Jan 15 '19 19:01 haydenadams

@conlan Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot avatar Jan 26 '19 17:01 gitcoinbot

replying to comment, still working on uniswap.info and speed optimizations (storing transaction data by day, month)

conlan avatar Jan 27 '19 11:01 conlan

@conlan Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot avatar Feb 07 '19 17:02 gitcoinbot

replying to comment, currently working on /chart endpoint, then adjusting crawler to also take transfer and approve events, and then lastly on to fee calculation for /user. Once those are in place we can automate exchanges added as created.

conlan avatar Feb 09 '19 09:02 conlan

@conlan Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot avatar Feb 13 '19 17:02 gitcoinbot

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@conlan due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] reminder (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot avatar Feb 16 '19 17:02 gitcoinbot

Still working on this @gitcoinbot. Scope has expanded slightly beyond initial expectations.

conlan avatar Feb 17 '19 01:02 conlan

https://github.com/Uniswap/uniswap-api/commit/46ddf9682555da953e9623de1595a0e5a534f5e5

conlan avatar Feb 19 '19 09:02 conlan

@conlan Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot avatar Feb 22 '19 17:02 gitcoinbot

Still working on this, finishing chart API, decided to add transaction_index to schema first. @gitcoinbot

conlan avatar Feb 22 '19 23:02 conlan

Fixed /chart endpoint and include transaction index in events now.

conlan avatar Feb 28 '19 11:02 conlan