Noaaan

Closing this due to lack of information. Feel free to re-open it should it still be a problem

How does this differ from https://github.com/wisp-forest/numismatic-overhaul/pull/101? Are there any improvements that could be made?

Feel free to re-contribute this to the 1.20 branch, and/or towards the 1.21 branch. The older, out-of-date branch was deleted as part of maintenance.

I can see several use cases for this. An example would be a way to transmute metal into gold, which would exclude wooden chests. There is also sorting related cases....

Generally the main benefits for implementing FTRAPI would be mod compat would be very straight forward - you would simply use Fabric API Lookup API (aka. FAPI API API) to...

You could likely fix this with a datapack, as we do support adding trades this way. See https://docs.wispforest.io/numismatic-overhaul/home/#villager-trades

Looking into this issue further: yeah. The Let's Do series does create trades in a way which isn't really supported. They register their own entity just like with a Wandering...

Please provide a full log, as per our [contributing guidelines](https://github.com/wisp-forest/.github/blob/main/CONTRIBUTING.md "A link to the Wisp Forest contributing guidelines").

In theory this should be doable. With your modpack you could simply ship a datapack which adds a trade to the Cartographer with the map, as we [do support selling...

Looking further into the issue it seems that Numismatic Overhaul's automatic trade converter only properly supports adding trades via Fabric API for modded villagers. You are still able to add...