MythicMetals icon indicating copy to clipboard operation
MythicMetals copied to clipboard

Published 20 hours ago • verified publisher icon Noaaan

Add German translation

Open Kurty00 opened this issue 1 year ago • 6 comments

Kurty00 avatar Aug 11 '23 19:08 Kurty00

Bumping this issue, as it seems to be stale

Noaaan avatar Oct 22 '23 17:10 Noaaan

Bumping this issue, as it seems to be stale

Sorry, didn't have much time lately... I fixed some of the untranslated strings in the most recent commit now.

Kurty00 avatar Oct 28 '23 20:10 Kurty00

All good. Gonna try to get a proper review of this so its merged next week 👍

Noaaan avatar Oct 28 '23 21:10 Noaaan

Bumping this pr, as it seems to be stale.

Kurty00 avatar Nov 16 '23 15:11 Kurty00

Sorry for this taking so long. Holidays set up all my german translation reviewers to be busy, including glisco. I have found someone with more MM knowledge to finally review the translation, and it should hopefully be done in the coming days/weeks. Going to post one of the review comments here, and add the rest of them once the review is complete.

Noaaan avatar Jan 10 '24 09:01 Noaaan

Alright, I addressed most of the issues you/your second party noted. If I didn't, I should have provided comments. Happy Easter!

Kurty00 avatar Mar 30 '24 13:03 Kurty00

I addressed the previously unresolved notes.

Kurty00 avatar Jun 08 '24 10:06 Kurty00

Ah thank you! Just to let you know, I plan on having this merged for the last 1.20 release, followed by porting it to 1.20.6+. A sidenote: some of the tag translations might change for the port, due to the major tag unification between NeoForge and Fabric. I would appreciate if you are available to look at it when the time comes

Noaaan avatar Jun 08 '24 12:06 Noaaan

If you need me to look at some changes in the translation, feel free to contact me.

Kurty00 avatar Jun 11 '24 11:06 Kurty00