RxFeedback.swift icon indicating copy to clipboard operation
RxFeedback.swift copied to clipboard

Add a public Observable alias to overcome Xcode 15 bug

Open johankool opened this issue 9 months ago • 6 comments

Fixes #66

johankool avatar Sep 18 '23 06:09 johankool

@freak4pc Hi! Is there any way you can merge this or #68 PRs and publish updated version for Cocoapods? Thanks

DmitriyAnd avatar Sep 20 '23 13:09 DmitriyAnd

@iandric any idea when will this be merged and a new release published? I'm currently blocked by this 🙏🏻

AboulEinein avatar Sep 20 '23 21:09 AboulEinein

@iandric any idea when will this be merged and a new release published? I'm currently blocked by this 🙏🏻

No, I'm not involved in the project; just tried to speed things up by reviewing and bumping this.

iandric avatar Sep 21 '23 08:09 iandric

There's no active maintainer for this project unfortunately. I can try and help in a few days but am preoccupied at the moment 🙏

freak4pc avatar Sep 21 '23 08:09 freak4pc

There's no active maintainer for this project unfortunately. I can try and help in a few days but am preoccupied at the moment 🙏

Gotcha @freak4pc, just created a new PR handling this, that also fixes Example app compilation. Also raised version to 4.0.1, so maybe that one could possibly be the one to get this fix merged?

iandric avatar Sep 21 '23 08:09 iandric

private func bindingsStrongify<Event, O, WeakOwner>(_ owner: WeakOwner, _ bindings: @escaping (WeakOwner, O) -> (Bindings<Event>)) -> (O) -> (Bindings<Event>) where WeakOwner: AnyObject { return { [weak owner] state -> Bindings<Event> in guard let strongOwner = owner else {

            return Bindings(subscriptions: [], events:  [Observable<Event>]())
        }
        return bindings(strongOwner, state)
    }

}

//Add this to Fix it public typealias Observable = RxSwift.Observable

brandy2015 avatar Nov 11 '23 07:11 brandy2015