playmaker icon indicating copy to clipboard operation
playmaker copied to clipboard

use standard fdroid repo dir layout

Open eighthave opened this issue 6 years ago • 8 comments

This is great work! I have one small request that'll make this integrate better into the F-Droid ecosystem: please use the standard directory layout. It seems right now this puts the repo straight into fdroid/. Instead it should look like:

-fdroid
       |-config.py
       \-repo
             |-index.xml
             |-my.package_123.apk

eighthave avatar Dec 28 '17 18:12 eighthave

I'm quite sure I'm using the standard fdroid layout. During initialization, the following commands are executed:

fdroid init -v
fdroid update --create-key -v

The last call is redundant for first time initialization, but it is useful in case the repo was already initialized but it's missing some required files.

This is the result of initialization:

pm-dir
        |-config.py
        |-archive/
        |-fdroid-icon.png
        |-keystore.jks
        |-metadata/
        |-srclibs/
        |-tmp/
        \-repo
            |-index-xml
            |-123.apk
            [...]

NoMore201 avatar Jan 04 '18 14:01 NoMore201

Yup, that looks standard. Perhaps you are using something different than fdroid server update to publish the repo to the webserver?

Also, you should check out the gitlab/github repo hosting. You could have Playmaker pushing repos to github for free hosting. See examples/config.py.

eighthave avatar Jan 04 '18 14:01 eighthave

@eighthave Which issue are you actually reporting here? That the repo is being served at domain.org/fdroid instead of domain.org/repo? Apart from that, the standard fdroid repo setup is being used.

Yannik avatar Jan 28 '18 20:01 Yannik

The full repo should have a basedir of fdroid/, e.g. domain.org/fdroid, then there should be a "repo" and "archive" sections there:

  • domain.org/fdroid/repo/index.xml
  • domain.org/fdroid/archive/index.xml

eighthave avatar Jan 30 '18 12:01 eighthave

Then domain.org/fdroid/index.html can optionally be used as a webpage to describe the repo.

eighthave avatar Jan 30 '18 13:01 eighthave

Since the current setup works, I guess that the fdroid app will check both these paths:

  • <playmaker_host>/fdroid/index.xml
  • <playmaker_host>/fdroid/repo/index.xml

right? If so, in the next version I'll change the base directory. The index.html thing i think could be done manually by users

NoMore201 avatar Jan 30 '18 16:01 NoMore201

Only fdroid/repo/index.xml is supported as a standard location.

eighthave avatar Jan 30 '18 16:01 eighthave

And yeah, the index.html would be done manually by the users. It would be nice to have an auto-generated version, but someone would have to implement that :-)

eighthave avatar Jan 30 '18 16:01 eighthave