Add Skills (Enchanter, Ardito, Wugushi, Sapper)

[felipecastagnarodecarvalho]

TODO/Missing features:

• Apply buffs on party members and pet as well
• Add Enchant Weapon Skill (the effect is applied once the player learns the skill)
• All Buff handler and Skill handlers can be improved as we learn more and add more properties/features. The code is not definitive and there is always open doors for improvements.

[felipecastagnarodecarvalho]

TODO:

• Make the skill rotate within the mouse position properly (how?)
• [DONE] Add knockback to Taglio Skill (I don`t know why inst working right now)

[felipecastagnarodecarvalho]

The sapper skill Spike Shooter is missing a few things:

• The ground effect (the object that fire the arrows) is not being displayed (not sure why) - I STILL DON'T KNOW
• [DONE] The arrows penetrates throw targets (The original skill makes the arrow disappears once it hits an enemy)

[felipecastagnarodecarvalho]

List of skills added:

Ardito:

• Granata
• Invasione
• Recupero
• Ritirarsi
• Taglio
• TreGranate

Enchanter:

• Agility
• EnchantAura
• EnchantEarth
• EnchantGlove
• OverReinforce

Sapper:

• BroomTrap
• Claymore
• LegHoldTrap
• PunjiStake
• SpikeShooter
• SpringTrap
• DetonateTrap

Wugushi:

• CrescendoBane
• GoldenFrog
• LatentVenom
• PoisonPot
• WideMiasma
• WugongGu
• Zhendu

[felipecastagnarodecarvalho]

Sapper:

• Can't show the explosion effect of the Claymore skill. I spend a lot of time on this but I can't identify why its not being displayed.
• Can't show the pillar (effect) for the Spike Shooter skill. Other effect that I am having issue to display somehow.
• Desync between the actual hitbox and skill effect for the skill Broom Trap It seems like the skill effect doesn't have a linear movement and it causes a desync.
• Detonate Trap doesn't show the explosion effect.

Wugushi

• Zhendu Buff effect is not present.
• Crescendo Bane Buff effect is not present.

Ardito:

• Everything seems to work fine with all the effects included.

Enchanter:

• Enchant Light Skill implementation missing (It should apply forever once the skill is learned)

[exectails]

What's the current status of this PR? I see there's a couple conflicts that need to be resolved, and based on your last comment there appear to be several issues still remaining. While a missing effect here and there might be acceptable for now, I'm somewhat concerned about the desyncs mentioned.

[felipecastagnarodecarvalho]

I am updating this PR right now. I should be done by the end of this week (15/06/2024). I see a lot of things that annoying me a bit. I will try to improve it as much as I can.

[exectails]

I just spent another 2 hours reading through only half of this PR, and the number of little issues and the amount of changes make the repeated reviews rather taxing and time consuming. For this reason, I'd like you to go over everything again, fix the mentioned issues across all of the code, and then try to cut the PR up a little into smaller chunks, maybe even down to one per skill if feasible.

I appreciate your work, and I apologize for the inconvenience, but as is, I can't even leave a comment without my browser lagging because of the size of the changes page^^"