Abbreve icon indicating copy to clipboard operation
Abbreve copied to clipboard

Put a word-wrap property for the => | errorMessage & isUserInputBlank | text which appear when either of both States are true.

Open PriyansuMaurya opened this issue 2 years ago • 33 comments

Description

When we put wrong slang or slang that is not present or the search bar is empty, we get a msg telling us the real problem like this

1. When slag is not present

- This entry does not exist in our records as of yet :(

  1. You can help us add this by creating a [github issue](https://github.com/Njong392/Abbreve)

  2. Or, you could fill out this [feedback form](https://t.co/mp86BLYBhq) and we will address the issue
  

2. When SearchBar is Empty

- Search bar 🔍 is Empty!. Please put abbreviation in search bar    

But when either of these messages appears, the content on its left gets displaced slightly to the left. it will more clear from the SS I have added below.

Screenshots

Screenshot (6)

Screenshot (7)

Screenshot (9)

Additional information

No response

PriyansuMaurya avatar Oct 06 '22 05:10 PriyansuMaurya

Sounds great, @PriyansuMaurya do you want me to assign this to you?

adropofilm avatar Oct 06 '22 07:10 adropofilm

No, I didn't put it to get this assigned to me, bcoz I don't know much about tailwind. it's for the general public, if it doesn't get solved this month, then definitely I will learn tailwind and try to solve it in the next month.

PriyansuMaurya avatar Oct 06 '22 15:10 PriyansuMaurya

No, I didn't put it to get this assigned to me, bcoz I don't know much about tailwind. it's for the general public, if it doesn't get solved this month, then definitely I will learn tailwind and try to solve it in the next month.

Thank you for raising this Priyansu! If no one takes this on, I'll try to go over it and see what I can do 💙

Njong392 avatar Oct 06 '22 17:10 Njong392

I can try to tackle this if that's cool with you @Njong392 ?

adropofilm avatar Oct 15 '22 07:10 adropofilm

@adropofilm are you still on this?

Njong392 avatar Oct 29 '22 18:10 Njong392

Hi friends, passing this on to anyone who wants to take it up. Been assigned to me for a while, sorry!

adropofilm avatar Nov 05 '22 22:11 adropofilm

I think it's safe to close this. Since we moved the search bar to the top, we don't have much of this problem anymore. What do you think @adropofilm

Njong392 avatar Nov 07 '22 00:11 Njong392

The bug has not been fixed till now although the search bar has been moved to the top. You can see this in the video 👇 Abbreve_Trim (2)

PriyansuMaurya avatar Nov 07 '22 06:11 PriyansuMaurya

Ooof... I somehow missed this issue. Thanks for the video @PriyansuMaurya I'll set out to fix some stuff this weekend.

Njong392 avatar Nov 23 '22 19:11 Njong392

Hi. Can I be assigned to this issue? I have experience with tailwind CSS.

TropicolX avatar Jan 16 '23 18:01 TropicolX

Hi there! Yes, sure. I'll assign you.

Njong392 avatar Jan 17 '23 02:01 Njong392

@Njong392 I've made a PR for the issue

TropicolX avatar Jan 19 '23 21:01 TropicolX

I saw. Thank you. I think replied to the pull request and suggested some changes.

Njong392 avatar Jan 19 '23 22:01 Njong392

@Njong392 I checked and this issue has not been resolved.....Can i be given the permission to work on this so we could close this issue.

newdydx avatar Feb 12 '23 13:02 newdydx

@newdydx i think the issue that the site has now is that the text near the search bar doesn't align with the content below it. It's shifted inward. And then continuously shifts outward as described by this issue.

Should I assign you still?

Njong392 avatar Feb 13 '23 14:02 Njong392

@Njong392 of course you can assign me...After going through the site I discovered the second issue had been resolved and the only issue left is the issue of the word wrap and I would love to work on the issue.....thanks

newdydx avatar Feb 13 '23 19:02 newdydx

Assigning you. Thank you for taking it on.

Njong392 avatar Feb 13 '23 20:02 Njong392

Oh wait. This issue is assigned to @TropicolX Would you still be interested in working on this?

Njong392 avatar Feb 13 '23 20:02 Njong392

@Njong392 still waiting to be assigned

newdydx avatar Feb 15 '23 11:02 newdydx

If by the weekend, the originally assigned person doesn't respond, I'll assign you then. All good?

Njong392 avatar Feb 15 '23 20:02 Njong392

@Njong392 no problem

newdydx avatar Feb 16 '23 09:02 newdydx

@newdydx assigning you to this now.

Njong392 avatar Feb 18 '23 06:02 Njong392

@Njong392 I made the pull request

newdydx avatar Feb 19 '23 21:02 newdydx

Has it been resolved?

devodii avatar Apr 22 '23 13:04 devodii

Has it been resolved?

Ah yes. This was fixed. However, the content on the page does not quite align and does not really look okay. Some sections are closer to the edges than others. Would you like to be assigned @devodii ?

Njong392 avatar Apr 24 '23 08:04 Njong392

Yes... Also, I've added a fancy scrollbar that matches the color. Supposed to be merged but you haven't. May I know why?

devodii avatar Apr 24 '23 09:04 devodii

@devodii I already reviewed your pull request. Please check the comments I made.

Njong392 avatar Apr 24 '23 09:04 Njong392

The caret in the search field seems to be hiding when it's focused but shows after the field is not null. Should i work on this?

https://user-images.githubusercontent.com/113144477/234280397-60116fef-8539-4e7e-9315-f46a8fda0e52.mp4

devodii avatar Apr 25 '23 12:04 devodii

This looks like an issue totally different from this one.It should be created separately. And I assigned you to this issue already btw

Njong392 avatar Apr 25 '23 14:04 Njong392

Oh... The one you assigned to me, i don't understand it. I guess it's the fact that the notFound message moves to the left when it has no record for the value inputed. Correct?

devodii avatar Apr 25 '23 20:04 devodii