TrinketMenu icon indicating copy to clipboard operation
TrinketMenu copied to clipboard

Add CurseBreaker support

Open egyjuzer opened this issue 4 years ago • 4 comments

hey, thanks for maintaining the addon. i can propose an alternative solution for the twitch client problems: a lot of players are started moving away from twitch client, because some addons, that were updated for the shadowlands pre-patch were not handles correctly and the non-classic version was installed. so a lot of players started using cursebreaker instead: https://github.com/AcidWeb/CurseBreaker all you need to do is define .pkgmeta-classic and .pkgmeta files, and cursebreaker handles the rest

egyjuzer avatar Oct 25 '20 06:10 egyjuzer

Heya!

A bit out of the loop, so this confused me a bit. Based on what I read cursebreaker is ment as an "alternative" to the twitch client, and uses custom links to addon repos, right?

I have never used a .pkgmeta file before, but I'll add it to my todolist, and have it added asap.

Thanks for the suggestion!

Nixxen avatar Nov 04 '20 08:11 Nixxen

no custom links work out of the box with:

  • curseforge links
  • wowinterface links
  • git repos (granted they have pkgmeta)

had problem with dominos so i decided to install it from git. it's pkgmeta for classic looks like this: https://github.com/tullamods/Dominos/blob/master/.pkgmeta-classic

egyjuzer avatar Nov 04 '20 08:11 egyjuzer

I have added a .pkgmeta-classic file and it looks correctly set up based on the way the Dominos addon had it set up. I'm away from my gaming PC for a good few months still, so won't be able to test the changes directly.

Let me know if there are any issues and I'll try to get them sorted ASAP.

Nixxen avatar Nov 08 '20 19:11 Nixxen

got past the initial error, now facing another:

CB> install https://github.com/Nixxen/TrinketMenu
0/1 | ----------------------------------------------------------------------------------------- |
RuntimeError: Failed to parse addon data: https://github.com/Nixxen/TrinketMenu
This integration supports only the projects that provide packaged releases.
CB>

this might be relevant: https://www.wowinterface.com/forums/showthread.php?t=55801 i think you also need to tags or some kind of "release"

egyjuzer avatar Nov 09 '20 20:11 egyjuzer