neuralforecast icon indicating copy to clipboard operation
neuralforecast copied to clipboard

Published 20 hours ago • verified publisher icon Nixtla

Addressing MLflow code issue #825

Open cargecla1 opened this issue 1 year ago • 3 comments

Addressing MLflow code example to integrate easily #825 https://github.com/Nixtla/neuralforecast/issues/825

cargecla1 avatar Feb 17 '24 14:02 cargecla1

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] avatar Feb 17 '24 14:02 review-notebook-app[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 17 '24 14:02 CLAassistant

Hello @jmoralez , Do you have time to look at this?

Cheers!

cla-ra3426 avatar Feb 19 '24 23:02 cla-ra3426

Hello @jmoralez ,

I just included all suggestions except for a suggestion to remove the #Registering model code section. I explained why on my comment to resolve that suggestion.

Thank you for all these suggestion! :)

cargecla1 avatar Apr 05 '24 12:04 cargecla1

Hey @cargecla1, I just pushed some changes. Please let me know if they look good to you, if they do we can merge this.

jmoralez avatar Apr 09 '24 17:04 jmoralez

Hey @cargecla1, I just pushed some changes. Please let me know if they look good to you, if they do we can merge this.

Hello @jmoralez ,

These changes look great, thank you for these additions! I believe this is now ready to merge.

Thank you very much for your support!

cargecla1 avatar Apr 10 '24 11:04 cargecla1

Thanks a lot for the contribution!

jmoralez avatar Apr 10 '24 16:04 jmoralez