neuralforecast icon indicating copy to clipboard operation
neuralforecast copied to clipboard

Default configs of AutoNHITS seems invalid

Open ArvidWeyrauch opened this issue 2 years ago • 3 comments

AutoNHITS.default_config is not a valid config if provided as argument since it uses 'input_size_multiplier', which is only translated to the necessary 'input_size' if config==None. This makes configs that are only slight modifications of the default unnecessarily cumbersome

After a rough scan of the code this seems to apply for most or all AutoModels

Version 1.5.0

ArvidWeyrauch avatar May 12 '23 08:05 ArvidWeyrauch

Hi @ArvidWeyrauch, the idea of our default config was precisely to only use it if config==None. This has the negative effect of requiring modifications (like removing input_size_multiplier) if you want to build on top of it.

We are working on improving this.

cchallu avatar May 29 '23 16:05 cchallu

Hi @cchallu, in that case I would suggest adapting section 3 of this page of the documentation, as it implies to me, both in the text and the comment in the code, that NHITS.default_config is a valid config. Also, consider making it protected (i.e. NHITS._defaults_config) to communicate it is not supposed to be accessed except by the class

ArvidWeyrauch avatar May 30 '23 06:05 ArvidWeyrauch

Thanks for the suggestion, we will improve the documentation.

cchallu avatar Jun 06 '23 23:06 cchallu