neuralforecast icon indicating copy to clipboard operation
neuralforecast copied to clipboard

Missing assert statement: Nbeats 'n_hidden' argument

Open alejandroxag opened this issue 3 years ago • 1 comments

When instantiating a Nbeats model, the init() argument 'n_hidden' must be a list of lists, one per 'stack_type,' so each corresponding set of NBeatsBlock is initialized passing a list as the 'theta_n_hidden' argument.

An assert statement in Nbeats.init() would help the user identify if this argument is properly stated, particularly when running grid routines (hyper optimization or ensembling), as the 'n_hidden' item in the grid needs to be defined as a list of lists of lists.

alejandroxag avatar Apr 27 '21 19:04 alejandroxag

I think it would be convenient to change the n_hidden name to n_hidden_list to make it more informative.

kdgutier avatar Apr 28 '21 00:04 kdgutier