neuralforecast icon indicating copy to clipboard operation
neuralforecast copied to clipboard
verified publisher icon Nixtla

Unused inferred frequency

Open AzulGarza opened this issue 4 years ago • 1 comments

I think the inferred frequency here is not used. Should we remove it?

https://github.com/Nixtla/neuralforecast/blob/09ce6d0075bbf287d78483d04f107dec7505fc5c/neuralforecast/data/tsdataset.py#L117

AzulGarza avatar Feb 10 '22 03:02 AzulGarza

Yes, I think so. So, A potential contributor should:

  • Check nf.data.tsdataset().get_frequency() and nf.data.tsdataset().frequency is not used by any model. In particular nf.esrnn.esrnn.*. https://github.com/Nixtla/neuralforecast/blob/09ce6d0075bbf287d78483d04f107dec7505fc5c/neuralforecast/data/tsdataset.py#L327-L330
  • Remove lines related to frequency in nf/data/tsdataset.py (using nbdev flow, of course).

:)

AzulGarza avatar Feb 10 '22 05:02 AzulGarza