patchelf icon indicating copy to clipboard operation
patchelf copied to clipboard

Add `--add-rpath-and-shrink` option to do both operations in one go

Open Ma27 opened this issue 1 year ago • 3 comments

Note: I know this is missing an update of the man-page and tests. I'd like to know if you'd be open to accept such a patch in the first place before investing more time into it.

The core issue is that --shrink-rpath doesn't free up space filled with X by --add-rpath, so using a combination of --add-rpath & --shrink-rpath on a virtual env will blow up shared libraries and cause them to segfault when loaded by Python at some point.

This is not an issue with Nix builds, but it absolutely is when using this in an imperatively managed virtualenv.

cc @Mic92


Thank you!

Please do your best to include a regression test so that the quality of future releases can be preserved.

Ma27 avatar Nov 15 '24 10:11 Ma27

@Ma27 I can probably just give you merge access to this project. I am currently not doing here much, because it feels a bit difficult to do any meaningful changes without breaking some random corner of nixpkgs.

Mic92 avatar Nov 16 '24 12:11 Mic92

Feel free to go ahead with this pull request: https://github.com/orgs/NixOS/teams/patchelf-maintainers/members

Mic92 avatar Nov 16 '24 13:11 Mic92

So first of all, your trust is greatly appreciated, thanks! ❤️

I'll try to bring this patch into a cleaner state within the next weeks to get it in.

That being said, I'm afraid I won't be able to exercise any further maintainer duties in a forseeable future (i.e. the next few months): I'm working on finishing my studies soonish and I can't afford a(nother) can of worms that a patchelf bump is for now (I know how painful updates in nixpkgs are).

If nothing has changed about the situation here in a few months, I'll reconsider my decision.

Ma27 avatar Dec 11 '24 08:12 Ma27