maintainers detected but not pinged?

[martinetd]

I'm curious why I wasn't pinged in this PR: https://github.com/NixOS/nixpkgs/pull/211126 (as a pahole maintainer)

According to the ofborg-eval-check-maintainers action I was listed as a potential maintainer: https://gist.github.com/GrahamcOfBorg/03fefe23cc2d730a4ac58f66d28872ed But I didn't receive any notification, nor see anything on the pull requests that'd hint I was mentioned.

Is there a limit to the maximum number of people being notified, or something like that?

[SuperSandro2000]

Yes, GitHub only allows to ping 15 people

[martinetd]

That's good to know... I only see 9 people in Cc on that ticket, but regardless of that particular limit would it be possible/make sense to just send a message with @ for people over the limit?

Rephrasing just to make sure I'm clear:

• make list of maintainers as currently
• only add people as maintainer like right now for the first x (not fussy on order, I assume there's already one)
• add a comment Notifying extra maintainers involved: @alice @bob [...] for others

In most cases I assume that'd make no difference but it'd avoid having a surprise when something is broken after an upgrade a maintainer isn't even aware of, and that'd be appreciated :)