ofborg icon indicating copy to clipboard operation
ofborg copied to clipboard

Eval tests should be executed with the lowest supported Nix version (2.3)

Open sternenseemann opened this issue 3 years ago • 4 comments

I ran into the first instance of path interpolation syntax slipping into nixpkgs today: https://github.com/NixOS/nixpkgs/pull/188466. Our lib/minver.nix prescribes that we support everything from 2.3 upwards.

Without CI to catch it, it is quite understandable that contributors accidentally introduce such changes (who remembers the changelog precisely?). Running the eval checks on the oldest supported Nix version should be enough, as any accepted Nix expressions under 2.3 should be forwards compatible.

sternenseemann avatar Aug 27 '22 08:08 sternenseemann

I made this mistake too: https://github.com/NixOS/nixpkgs/pull/210207

OfBorg really needs to check this.

ghost avatar Mar 12 '23 02:03 ghost

This would also remove all performance optimizations done since the minimum supported versions.

SuperSandro2000 avatar Mar 12 '23 23:03 SuperSandro2000

This is now implemented in Nixpkgs directly: https://github.com/NixOS/nixpkgs/commit/013acf2396f451c73b6cd6b0148df21cbaa4c165

infinisil avatar Jul 20 '23 00:07 infinisil

Here is the explanation by @infinisil about the minimum supported Nix version on NixOS Discourse:

https://discourse.nixos.org/t/when-is-a-nix-builtin-function-builtins-considered-ready-to-be-used-inside-nixpkgs/35369/2

ShamrockLee avatar Dec 10 '23 22:12 ShamrockLee